[
https://issues.apache.org/jira/browse/SOLR-17217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-17217:
--------------------------------------
Attachment: SOLR-17217.short.patch
SOLR-17217.long.patch
Status: Open (was: Open)
Attaching 2 patch files.
The "short" patch file is the actual code change: adding versions of
{{SolrTestCase.assertThat}} (that use {{MatcherAssert.assertThat}}) to hide the
inherited (but deprecated) versions from {{LuceneTestCase}}.
The long patch is what you get if you run the following commands on the code
base...
{noformat}
find -name \*.java | xargs perl -i -nle
's/MatcherAssert\.assertThat/assertThat/g; print unless /import
org.hamcrest.MatcherAssert;/'
{noformat}
...then apply the "small" patch and run {{gradle tidy}}
(rerunning those steps on 9x will almost certainly be easier then then trying
to actually backport the full "long" patch)
> simplify verbose MatcherAssert.assertThat usage
> -----------------------------------------------
>
> Key: SOLR-17217
> URL: https://issues.apache.org/jira/browse/SOLR-17217
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-17217.long.patch, SOLR-17217.short.patch
>
>
> Backstory...
> [https://lists.apache.org/thread/nycfk6b2bqkqsbq29snow51w31qo1dd3]
> [https://github.com/policeman-tools/forbidden-apis/issues/237]
>
> Now that we've upgraded to forbidden-apis 3.7+, we can simplify the verbosity
> for folks wanting to use {{assertThat}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
