epugh opened a new pull request, #2378: URL: https://github.com/apache/solr/pull/2378
https://issues.apache.org/jira/browse/SOLR-17194 # Description We pass in a httpClient builder to CloudHttp2SolrClient, but in at least this code path we never use, so we have a null httpClient, which means we build a default one, which means if you passed one in then you don't get your Basic Auth params! # Solution A test and a small fix. I did not try to reasoon about all the builder stuff.. I find the combination of httpClient, and the solrClient and their various builders VERY hard to understand... I wrote at test, I fixed the code, the test passes... # Tests Added a test to the Export Tool # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
