HoustonPutman commented on code in PR #2384: URL: https://github.com/apache/solr/pull/2384#discussion_r1546952877
########## solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java: ########## @@ -314,15 +314,19 @@ public void execute(final Runnable command) { if (t instanceof OutOfMemoryError) { throw t; } - if (enableSubmitterStackTrace) { Review Comment: I don't believe so. So the `baseCause`, which is now always logged, will be `t` (the real throwable) if `submitterStackTrace` is `null`. Since when `enableSumbitterStackTrace==false` then `submitterStackTrace=null` (logic from above), then we will only be logging `t` if `enableSubmitterStackTrace==false`. The submitterStackTraces will only be included if `enableSubmitterStackTrace==true`. It is still a little different than the previous logic, which only logged the error message, but I think the spirit of the flag is still the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org