magibney commented on code in PR #1557:
URL: https://github.com/apache/solr/pull/1557#discussion_r1547713877
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -427,7 +429,16 @@ public SolrIndexSearcher(
}
public SolrDocumentFetcher getDocFetcher() {
- return docFetcher;
+ try {
+ return docFetcher.createInstance();
+ } catch (IOException e) {
+ // TODO: should we instead throw IOException?
+ throw new RuntimeIOException(e);
Review Comment:
Should we still just wrap in a regular RuntimeException and throw, then
(addressing the TODO)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
