magibney commented on code in PR #2293: URL: https://github.com/apache/solr/pull/2293#discussion_r1548691128
########## solr/core/src/test/org/apache/solr/logging/TestLogWatcher.java: ########## @@ -104,4 +121,56 @@ public void testLog4jWatcher() throws InterruptedException { oldMessages.add(msg); } } + + /** + * Here we validate that serialization works as expected for several different methods. Ideally we + * would use actual serialization from Jersey/Jackson, since this is what really happens in V2 + * APIs. But this is simpler, and should give us roughly equivalent assurances. + */ Review Comment: No problem, and thanks for the review/suggestion! I'll probably go ahead and commit as-is; have to make sure this gets in 9.6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org