mlbiscoc opened a new pull request, #2405:
URL: https://github.com/apache/solr/pull/2405

   https://issues.apache.org/jira/browse/SOLR-10654
   
   **This is currently a draft PR. Unit tests have not been written yet. PR 
created to get feedback on current implementation**
   
   # Description
   
   Introduce a new Prometheus response writer 
`/solr/admin/metrics?wt=prometheus` to output Solr Core registry metrics 
directly from Solr. Output looks similar to the prometheus exporter. This is 
only `solr.core` registry. Other registry planned to be outputted in future PRs.
   
   Output example:
   [cloud.txt](https://github.com/apache/solr/files/15013185/cloud.txt)
   
[standalone.txt](https://github.com/apache/solr/files/15013186/standalone.txt)
   
   # Solution
   
   Currently, Solr metrics are collected by Dropwizard and differentiated by 
metric names. This is an anti-pattern to Prometheus. Manually export Dropwizard 
Solr core registry metrics into a prometheus registry and parse out the labels 
from the metric name to be added to prometheus metrics.
   
   **NOTE: Not all metrics are possible to convert to Prometheus such as 
Dropwizard string metrics. This is because Prometheus does not non-numeric 
types**
   
   # Tests
   
   Draft PR. Tests have not been written yet. Will update accordingly.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to