magibney commented on PR #2410: URL: https://github.com/apache/solr/pull/2410#issuecomment-2066626472
javadoc should be updated on [HttpSolrClientBuilderBase.withMaxConnectionsPerHost(int)](https://github.com/apache/solr/blob/188ca8872cdbe61ea229bc40fadee20e7ba50053/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java#L108-L111), explaining the new difference between how this is handled for http1 vs http2. I wonder, to approximate similar high-level behavior for http1 vs http2, could the http2 client, under the hood, interpret this setting as `((maxConnectionsPerDest - 1) / 300) + 1`, or something? I don't like having that 300 constant hardcoded there, as presumably the multiplexing factor in jetty could change ... but idk, something along those lines might address [Sanjay's concern](https://issues.apache.org/jira/browse/SOLR-17240?focusedCommentId=17838863#comment-17838863). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
