[ https://issues.apache.org/jira/browse/SOLR-17222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839039#comment-17839039 ]
ASF subversion and git services commented on SOLR-17222: -------------------------------------------------------- Commit 8afd6975ff5c32c38adc1216efa3d5d24a36f111 in solr's branch refs/heads/main from Michael Gibney [ https://gitbox.apache.org/repos/asf?p=solr.git;h=8afd6975ff5 ] SOLR-17222: QueryResponseWriterUtil.NonFlushingStream should support bulk write methods (#2386) > QueryResponseWriterUtil.NonFlushingStream should support bulk write methods > --------------------------------------------------------------------------- > > Key: SOLR-17222 > URL: https://issues.apache.org/jira/browse/SOLR-17222 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Affects Versions: main (10.0), 9.5.0 > Reporter: Michael Gibney > Priority: Trivial > Time Spent: 20m > Remaining Estimate: 0h > > All text responses (non-javabin) are currently serialized through > {{QueryResponseWriterUtil.NonFlushingStream}}. The minimal method override in > that class means that every byte written on all text responses is iterated > and copied byte-for-byte. > It is trivial to extend {{FilterOutputStream}} and override the bulk write > methods, eliminating this potential bottleneck. This came on my radar while > doing [general investigation into response serialization > slowness|https://github.com/apache/solr/pull/1440#issuecomment-1462597683]. I > haven't bothered to benchmark this, but it's a trivial change and could only > be a good thing, in terms of performance. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org