gus-asf commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-2070903192
I guess the question is more a matter of how safe you think this change is... We all know that there are some flaky tests. The test doesn't sound related (being admin/recovery related not query related) doesn't matter much assuming it doesn't reproduce with the seed, or seem to fail more frequently. I haven't published the RC yet, though I have already run tests locally and should re-do that if we are going to add new commits. -Gus On Mon, Apr 22, 2024 at 3:44 PM David Smiley ***@***.***> wrote: > Shall I just merge this for 9.6? I think it's embarrassing we've had this > perf issue for so long without it being noticed. match-all-docs is so > common, like in ping queries for one. > > One test failed, TestPrepRecovery.testLeaderNotResponding but it's a > common flapper > <https://ge.apache.org/scans/tests?search.relativeStartTime=P28D&search.rootProjectNames=solr-root&search.timeZoneId=America%2FNew_York&tests.container=org.apache.solr.cloud.TestPrepRecovery> > > CC @gus-asf <https://github.com/gus-asf> (9.6 RM) > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/solr/pull/2221#issuecomment-2070806945>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALF2L3IFCJ6F3JJSIZGGKKLY6VR73AVCNFSM6AAAAABCJOYDZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZQHAYDMOJUGU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- http://www.needhamsoftware.com (work) https://a.co/d/b2sZLD9 (my fantasy fiction book) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
