[ 
https://issues.apache.org/jira/browse/SOLR-16974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840872#comment-17840872
 ] 

Ilan Ginzburg commented on SOLR-16974:
--------------------------------------

Looking at the [SolrCore constructor 
call|https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/core/SolrCore.java#L1076]
 to build a 
[CircuitBreakerRegistry|https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java#L65]
 it seems we redo the static configuration again for each core (even though the 
configuration is not core specific)

> Global Circuit Breakers
> -----------------------
>
>                 Key: SOLR-16974
>                 URL: https://issues.apache.org/jira/browse/SOLR-16974
>             Project: Solr
>          Issue Type: New Feature
>          Components: Circuit Breakers
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>            Priority: Major
>             Fix For: 9.5
>
>          Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> Currently Circuit Breakers are configured per core in solrconfig.xml. 
> However, cores/collections do not live in isolation, and it could be that a 
> cluster administrator would like to enforce circuit breakers for the entire 
> cluster.
> I'm not clear as to whether we need both cluster level and a core level 
> pluggability. And would core-level breakers add to any cluster-level ones or 
> override them for that core?
> A potential design is to add this as a new plugin in solr.xml, and have them 
> added in a new static context of CircuitBreakerRegistry. Then the isTripped 
> logic would consult both the per-core list and the static/global list of 
> breakers.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to