Gus Heck created SOLR-17258:
-------------------------------

             Summary: Possibly avoid the use of pushd and popd in release wizard
                 Key: SOLR-17258
                 URL: https://issues.apache.org/jira/browse/SOLR-17258
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
          Components: release-scripts
            Reporter: Gus Heck


When the release wizard is executing a series of commands and hits an error the 
release manager will need to fix the problem and run the remaining commands 
manually. For example in the 9.6 release SOLR-17250 caused me to error out at 
line 18 of the following:
{code:java}
  cd ~/.solr-releases/9.6.0
  # Run this command to clone the solr-docker git repo
  git clone --progress https://gitbox.apache.org/repos/asf/solr-docker.git 
solr-docker
  # Checkout the most recent main version
  pushd solr-docker
  git checkout main && git pull --ff-only
  popd
  # Add the new full distribution Dockerfile to the repo
  pushd solr-docker
  mkdir -p 9.6 && cp 
~/.solr-releases/9.6.0/RC1/dist/solr-9.6.0-RC1-rev-f8e5a93c11267e13b7b43005a428bfb910ac6e57/solr/9.6.0/docker/Dockerfile.official-full
 9.6/Dockerfile
  popd
  # Add the new slim distribution Dockerfile to the repo
  pushd solr-docker
  mkdir -p 9.6-slim && cp 
~/.solr-releases/9.6.0/RC1/dist/solr-9.6.0-RC1-rev-f8e5a93c11267e13b7b43005a428bfb910ac6e57/solr/9.6.0/docker/Dockerfile.official-slim
 9.6-slim/Dockerfile
  popd
  # Commit the new Dockerfile
  pushd solr-docker
  git add 9.6/Dockerfile 9.6-slim/Dockerfile && git commit -m "Apache Solr 
release 9.6.0"
  popd
  # Check that the commit looks correct. Only two Dockerfiles (full and slim) 
should be added or updated.
  pushd solr-docker
  git show HEAD
  popd
  # Push the commit
  pushd solr-docker
  git push
  popd
 {code}
However the next command is popd and I have to make a careful (and likely error 
prone) backtrack through the script to understand where the push/pop path was 
so I can manually "pop" to the right location.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to