laminelam commented on code in PR #2417:
URL: https://github.com/apache/solr/pull/2417#discussion_r1583499845
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java:
##########
@@ -379,7 +387,7 @@ public CloudLegacySolrClient build() {
"Both zkHost(s) & solrUrl(s) have been specified. Only specify
one.");
} else if (!zkHosts.isEmpty()) {
this.stateProvider =
- ClusterStateProvider.newZkClusterStateProvider(zkHosts,
zkChroot, canUseZkACLs);
+ ClusterStateProvider.newZkClusterStateProvider(zkHosts,
zkChroot, canUseZkACLs, solrClassLoader);
Review Comment:
I am not really sure to understand why did you mean here.
_ZkStateReader_ to call _newZkClusterStateProvider_ method?
Wouldn't this end up in a recursive call?
BTW, _ZkStateReader_ doesn't have access to _SolrRecourceLoader_ neither
(runs under solrj*).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
