[
https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842689#comment-17842689
]
James Dyer commented on SOLR-17263:
-----------------------------------
[~andywebb1975] Thank you for being an early adopter of this new client, for
reporting the bug and for the PR with the fix.
Sorry for the dueling PR's, but can you review my follow-up PR to yours,
[2435|https://github.com/apache/solr/pull/2435]?
I added a unit test and found sure enough that this affects the Jdk client but
the existing Jetty Client handles the parameters properly. The test indicates
only GET is affected by this bug but POST and PUT requests are OK. In the
follow-up PR I modified your fix to be only for GET.
> HttpJdkSolrClient doesn't encode curly braces etc
> -------------------------------------------------
>
> Key: SOLR-17263
> URL: https://issues.apache.org/jira/browse/SOLR-17263
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: 9.6.0
> Reporter: Andy Webb
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Ref
> https://issues.apache.org/jira/browse/SOLR-599?focusedCommentId=17842429#comment-17842429
> - {{HttpJdkSolrClient}} should use {{{}SolrParams{}}}' {{toQueryString()}}
> method when constructing URLs to that all URL-unsafe characters are encoded.
> It's implicitly using the {{toString()}} method currently which is intended
> for logging etc purposes.
> Attempting to use alternate query parsers in requests as shown below will
> currently fail as the curly braces aren't encoded.
> {noformat}
> myquery.set("fq", "{!terms f=myfield}value1,value2"); {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
