kotman12 commented on PR #2382: URL: https://github.com/apache/solr/pull/2382#issuecomment-2089353858
> Ease of configuration might be a reason? Or could one imagine a scenario where indexing and searching wish to use different presearcher types or settings? I think it would be difficult to support defined behavior if a different presearcher configuration was used for indexing vs search. I am sure there is some scenario where this is useful but I think it is tricky to implement. Moreover, lucene's `Monitor` shares the [same presearcher instance](https://github.com/apache/lucene/blob/main/lucene/monitor/src/java/org/apache/lucene/monitor/Monitor.java#L46C31-L46C42) for both sides of its API. > Here I was temporarily a little confused, the ReverseQueryParser seems to do little parsing but more post-processing on the json-to-document parsing done by ReverseSearchComponent.documentBatch previously .. I am confused too! I didn't pay a lot of attention to this but I'll try to see if I can remove these two bits and just stick the logic in the `ReverseSearchComponent`. I'll reply otherwise if I can think of any good reason for this superfluous separation of duties that really seem very related. > ReverseSearchComponent extends QueryComponent inheritance instead. I think I like this idea a lot and am willing to try it out unless you beat me to it! I must say I also very much like the neatly-packaged `ReverseSearchHandler` idea which is actually well-defined in code and reduces the need for boilerplate config of potential users. > SimpleQueryParser seems to wrap the default parser. Yes, but its also a `SolrQueryRequest` which the parser needs to satisfy its contract. I know its a hack so I'm open to a better idea of wrapping this. A user should be able to specify a query and route to any query parser they want using the standard `{! .. }` prefix and `QParser.getParser(String, SolrQueryRequest)` seems to do just that (i.e. I have both xml and default queries indexed in the tests). I wanted to also support additional query parameters on top of the query string (since the query is really a function of both, think default fields) but I haven't gotten to that yet. You'll notice that `SimpleQueryParser:getParams` method is empty (for now). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
