markrmiller commented on code in PR #2432:
URL: https://github.com/apache/solr/pull/2432#discussion_r1596499979
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -2849,9 +2834,14 @@ public boolean
checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) {
* Best effort to set DOWN state for all replicas on node.
*
* @param nodeName to operate on
+ * @return the names of the collections that have replicas on the given node
*/
- public void publishNodeAsDown(String nodeName) {
+ public Collection<String> publishNodeAsDown(String nodeName) {
log.info("Publish node={} as DOWN", nodeName);
+
+ ClusterState clusterState = cc.getZkController().getClusterState();
+ Map<String, List<Replica>> replicasPerCollectionOnNode =
+ clusterState.getReplicaNamesPerCollectionOnNode(nodeName);
Review Comment:
I'd keep that overseer alive somewhere. It would make an excellent case
study. I think it's pretty rare - I'm hard pressed to think of anything I've
ever run into that comes close to its performance / cluster impact in
comparison to the infrequent number of bits it actually has to manage and
distribute. It's honestly breath taking in its own way. The level of
independence in its work, the amount of information involved ... if I ever
teach a software course, I'd pull it out of a jar. You can't just waltz into
code like that. There are a lot of lessons tied up in that code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
