cpoerschke commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1601740654
########## solr/modules/monitor/src/java/org/apache/lucene/monitor/MonitorFields.java: ########## @@ -0,0 +1,38 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) under one or more + * * contributor license agreements. See the NOTICE file distributed with + * * this work for additional information regarding copyright ownership. + * * The ASF licenses this file to You under the Apache License, Version 2.0 + * * (the "License"); you may not use this file except in compliance with + * * the License. You may obtain a copy of the License at + * * + * * http://www.apache.org/licenses/LICENSE-2.0 + * * + * * Unless required by applicable law or agreed to in writing, software + * * distributed under the License is distributed on an "AS IS" BASIS, + * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * * See the License for the specific language governing permissions and + * * limitations under the License. + * + */ + +package org.apache.lucene.monitor; + +import java.util.Set; + +public class MonitorFields { + + public static final String QUERY_ID = QueryIndex.FIELDS.query_id + "_"; + public static final String CACHE_ID = QueryIndex.FIELDS.cache_id + "_"; + public static final String MONITOR_QUERY = QueryIndex.FIELDS.mq + "_"; + public static final String PAYLOAD = QueryIndex.FIELDS.mq + "_payload_"; Review Comment: The https://github.com/cpoerschke/solr/commit/26f932bc077cc2fc1abd553480e9efe715a6f7c5 commit on https://github.com/cpoerschke/solr/commits/solr-monitor-cpoerschke-3 explores turning the `MonitorFields.PAYLOAD` constant into a configurable. And interesting insight from that is the co-occurrence of `org.apache.lucene.monitor.QueryDecomposer` and `String payloadFieldName` -- not yet explored if maybe inheritance might be a thing. ``` class SolrQueryDecomposer extends org.apache.lucene.monitor.QueryDecomposer { String payloadFieldName; } ``` Also (note-to-self) looking to understand further w.r.t. query decomposer vs. query decoder and how the field names fit into that picture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
