dsmiley commented on code in PR #2467: URL: https://github.com/apache/solr/pull/2467#discussion_r1606945391
########## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ########## @@ -149,10 +149,6 @@ public void addListenerFactory(HttpListenerFactory factory) { this.listenerFactory.add(factory); } - public List<HttpListenerFactory> getListenerFactory() { Review Comment: Uh, you are removing a public method of an important SolrJ class? That should not be done without backwards compatibility considerations. Leave it please. Mark it deprecated if you prefer. The "add" method should be deprecated (for immutability). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org