mlbiscoc commented on code in PR #2405:
URL: https://github.com/apache/solr/pull/2405#discussion_r1612305244


##########
solr/core/src/java/org/apache/solr/metrics/prometheus/PrometheusCoreExporterInfo.java:
##########
@@ -30,4 +32,7 @@ enum CoreCategory {
     INDEX,
     CORE
   }
+
+  String PROMETHEUS_CLOUD_CORE_REGEX = 
"^core_(.*)_(shard[0-9]+)_(replica_n[0-9]+)$";
+  Pattern PROMETHEUS_CLOUD_CORE_PATTERN = 
Pattern.compile(PROMETHEUS_CLOUD_CORE_REGEX);

Review Comment:
   You're right dropped `PROMETHEUS` in the prefix and also removed the 
`PROMETHEUS_CLOUD_CORE_REGEX` constant



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to