dsmiley commented on code in PR #2351:
URL: https://github.com/apache/solr/pull/2351#discussion_r1613436293
##########
solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java:
##########
@@ -236,11 +246,17 @@ public SolrMetricsContext getSolrMetricsContext() {
return solrMetricsContext;
}
- // if you are looking for a client to use, it's probably this one.
+ // please use getDefaultHttpSolrClient instead.
+ @Deprecated(since = "9.6")
public HttpClient getDefaultHttpClient() {
return defaultClient;
}
+ // if you are looking for a client to use, it's probably this one.
Review Comment:
As we are introducing an Http2SolrClient to use instead of an (Apache)
HttpClient, this isn't a refactoring. So now is an appropriate time to think
about where best to place this new client so that we needn't go updating all
the callers an additional time. We agree UpdateShardHandler doesn't make sense
because it's not for updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
