markrmiller commented on code in PR #2461:
URL: https://github.com/apache/solr/pull/2461#discussion_r1613822238
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java:
##########
@@ -566,24 +576,28 @@ public NamedList<Object> request(final SolrRequest<?>
request, String collection
if (!success) {
// stall prevention
int currentQueueSize = queue.size();
+ long currentTime = System.nanoTime();
+ long processed = processedCount.sum();
Review Comment:
> [Q] Should we still be comparing queue-sizes in L581 below? As you've
highlighted in the JIRA ticket and this PR description - queue size isn't a
pretty ambivalent indicator of whether the queue processing is stalled or not.
Answered in the first comment: "There is no real reason you need to check
the size of the queue as well, but I just kept it anyway."
I don't believe it adds anything, but I just kept this first draft patch to
bare minimum changes basically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
