dsmiley commented on PR #1570: URL: https://github.com/apache/solr/pull/1570#issuecomment-2136032515
Sorry, but I strongly object to ModifiableSolrParams being a home for this method. SolrParams and subclasses are a generic data structure intended for params but they don't (nor do I think they should!) know about any particular parameter. I think this may be the first case where a SolrParams bit of code has knowledge about a specific parameter. Imagine if JDK's HashMap had special knowledge of certain keys? Yuck, right? I think ShardHandler would be a better location for such a utility method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
