janhoy commented on code in PR #1768:
URL: https://github.com/apache/solr/pull/1768#discussion_r1622383331
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -80,30 +83,72 @@ public class SolrCLI implements CLIO {
public static final String ZK_HOST = "localhost:9983";
+ public static final Option OPTION_ZKHOST_DEPRECATED =
+ Option.builder("zkHost")
+ .longOpt("zkHost")
+ .deprecated(
+ DeprecatedAttributes.builder()
+ .setForRemoval(true)
+ .setSince("9.6")
+ .setDescription("Use --zk-host instead")
+ .get())
+ .argName("HOST")
+ .hasArg()
+ .required(false)
+ .desc(
+ "Zookeeper connection string; unnecessary if ZK_HOST is defined
in solr.in.sh; otherwise, defaults to "
+ + ZK_HOST
+ + '.')
+ .build();
+
public static final Option OPTION_ZKHOST =
Option.builder("z")
- .longOpt("zkHost")
+ .longOpt("zk-host")
.argName("HOST")
.hasArg()
.required(false)
.desc(
"Zookeeper connection string; unnecessary if ZK_HOST is defined
in solr.in.sh; otherwise, defaults to "
+ ZK_HOST
+ '.')
- .longOpt("zkHost")
.build();
- public static final Option OPTION_SOLRURL =
+ public static final Option OPTION_SOLRURL_DEPRECATED =
Option.builder("solrUrl")
+ .longOpt("solrUrl")
+ .deprecated(
+ DeprecatedAttributes.builder()
+ .setForRemoval(true)
+ .setSince("9.6")
Review Comment:
```suggestion
.setSince("9.7")
```
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -80,30 +83,72 @@ public class SolrCLI implements CLIO {
public static final String ZK_HOST = "localhost:9983";
+ public static final Option OPTION_ZKHOST_DEPRECATED =
+ Option.builder("zkHost")
+ .longOpt("zkHost")
+ .deprecated(
+ DeprecatedAttributes.builder()
+ .setForRemoval(true)
+ .setSince("9.6")
Review Comment:
```suggestion
.setSince("9.7")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
