uvatbc opened a new pull request, #2498: URL: https://github.com/apache/solr/pull/2498
https://issues.apache.org/jira/browse/SOLR-XXXXX <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description The Solr project is considering the usage of JDK 21 at some point. We need to control which JDK is used in Crave. # Solution A crave.yaml file at the top of the source repository is read by Crave to override any Crave defaults. This change introduces the file, with the image override for JDK 21. # Tests I ran the following command on my private branch with this file and against the upstream Solr, and saw that the new JDK has been used with this change. Before change: https://foss.crave.io/app/#/build/info/109405?team=5 ``` javac 11.0.23 ``` After change: https://foss.crave.io/app/#/build/info/109418?team=5 ``` javac 21.0.3 ``` Full log output: ``` 14:15:01 admin@Uv-MacAir:/crave-devspaces/solr/uvatbc$ git checkout main Switched to branch 'main' Your branch is up to date with 'origin/main'. 14:20:18 admin@Uv-MacAir:/crave-devspaces/solr/uvatbc$ crave run -- javac --version Selecting project Solr (id:39) Picking up local changes (if any)... Waiting for build id:109405 to start... Error: Could not start service links, since job is no longer running Setting up workspace (this could take some time)... Pulling container image accupara/openjdk:11... Finished pulling container image accupara/openjdk@sha256:4f56da3bde6640dcff1440d8429ec770d44f3d94985a2eb3d2253ed1885f9933 took 977.339733ms using branch "main" setting commitID to 31e85fb6d87d2f70e92501d4df065d0c9ed3a466 javac 11.0.23 ------------------------------------------------------------------------ Build Successful Total time: 18s ------------------------------------------------------------------------ Build logs saved at: https://foss.crave.io/app/#/build/info/109405?team=5 14:23:35 admin@Uv-MacAir:/crave-devspaces/solr/uvatbc$ git checkout crave-jdk-21 Switched to branch 'crave-jdk-21' 15:06:07 admin@Uv-MacAir:/crave-devspaces/solr/uvatbc$ crave run -- javac --version Selecting project Solr (id:39) Picking up local changes (if any)... 1 file changed, 2 insertions(+) Waiting for build id:109418 to start... Error: 2024/06/05 15:10:36 client: Connection error: server: access to port 10.128.15.194:7091:3 denied err: <nil> Error: 2024/06/05 15:10:37 client: Connection error: server: access to port 10.128.15.194:7546:3 denied err: <nil> Services in this job can be accessed using the following: Service Remote Access URL --------- -------- ------------------------ ssh 22 ssh://localhost:40279 vscode 5899 vscode://localhost:39035 Setting up workspace (this could take some time)... Pulling container image accupara/openjdk:21... Finished pulling container image accupara/openjdk@sha256:903dbc01cdd18791ffd4a8ee710f5a7f499bd664fd9ee85a42f7f548c41aabce took 12.942741237s Switched to a new branch 'crave-jdk-21' setting commitID to 31e85fb6d87d2f70e92501d4df065d0c9ed3a466 From /home/admin/.craved/mcduSuBhHKKD-8a8cf14e400f0b9cf5fc12fd7d51bb83ea225229.patch.gz.b64 * branch HEAD -> FETCH_HEAD Updating 31e85fb6d87..9fa39c70e56 Fast-forward crave.yaml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 crave.yaml javac 21.0.3 ------------------------------------------------------------------------ Build Successful Total time: 31s ------------------------------------------------------------------------ Build logs saved at: https://foss.crave.io/app/#/build/info/109418?team=5 ``` # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
