iamsanjay commented on PR #2501: URL: https://github.com/apache/solr/pull/2501#issuecomment-2157166055
All the usages of `new URL` (except one) has been replaced with `URI.create(url).toURL()`. The exception was one specific case which is testing the presence of caret in the URL as It was an old issues (https://issues.apache.org/jira/browse/SOLR-5971) that failed due to the caret. Now replacing it with new Syntax fails because caret is in the disallowed list for URI and thus failed. I do not want to encode the character, because the whole point of test is to test caret without encoding it, instead I used `@SuppressForbidden`. Because #2497 is still in progress, So, meanwhile, I added "new URL" to the forbidden api to make sure no one would use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
