cpoerschke commented on code in PR #2022:
URL: https://github.com/apache/solr/pull/2022#discussion_r1636945501
##########
solr/modules/ltr/src/java/org/apache/solr/ltr/interleaving/LTRInterleavingScoringQuery.java:
##########
@@ -45,4 +45,30 @@ public Set<Integer> getPickedInterleavingDocIds() {
public void setPickedInterleavingDocIds(Set<Integer>
pickedInterleavingDocIds) {
this.pickedInterleavingDocIds = pickedInterleavingDocIds;
}
+
+ @Override
+ public LTRScoringQuery clone() {
+ LTRInterleavingScoringQuery cloned =
+ new LTRInterleavingScoringQuery(
+ getScoringModel(), getExternalFeatureInfo(), getThreadModule());
+ cloned.setOriginalQuery(getOriginalQuery());
+ cloned.setFeatureLogger(getFeatureLogger());
+ cloned.setRequest(getRequest());
+ cloned.setPickedInterleavingDocIds(getPickedInterleavingDocIds());
Review Comment:
wondering if the `efi` map and the `pickedDocIds` set should be cloned too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
