stephen-woods commented on PR #2506: URL: https://github.com/apache/solr/pull/2506#issuecomment-2174510200
Assuming I understood what @madrob was getting at when mentioning Bloch's flexibility argument, I attempted to refactor this PR in order to to introduce a type parameter to the `RankQuery` class... Now, the `getTopDocsCollector` method returns an invariant type. **Note** that this actually makes things _less_ flexible, since the rank query can no longer return `TopDocCollectors` of different types (though, honestly... locking it down to a single type might actually be a good thing). So as not to undo the work that has already been done on this PR, I'm including a link to a branch on my fork that includes this refactoring. Again, this is a breaking change that will cause compilation issues for third party plugin developers. I'm not convinced that this is appropriate for a minor version change on the 9.x branch, but it might be alright on main (10.X) if enough people like it. If you want, I can make a separate PR for this new approach to make discussing a little easier. https://github.com/stephen-woods/solr/tree/SOLR-17322generic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
