dsmiley opened a new pull request, #2524: URL: https://github.com/apache/solr/pull/2524
IMO it's wrong for SolrIndexSearcher.search(QueryCommand) to also take a QueryResult param and not return it. It's an "out" parameter, but there is no need for this! This PR deprecates that method and replaces it with one that does the right thing. In one spot, I see QueryResult early segment termination being set up in QueryComponent but that should be done in SolrIndexSearcher. I also deprecated many low-value SolrIndexSearcher methods involving QueryCommand; a QueryCommand is a superior API to methods taking lots of parameters. Some weren't even called. Some were in a place or two. I inlined some of those albeit not all. Some were called by SolrPluginUtils methods that themselves felt like questionable utility methods so I deprecated them too; they are used by DebugComponent and MLTHandler but IMO if they need to exist, DebugComponent would be the best home as it's the principal place for debut output to be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
