cpoerschke commented on code in PR #2526:
URL: https://github.com/apache/solr/pull/2526#discussion_r1650892906


##########
solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java:
##########
@@ -181,16 +183,28 @@ public void modifyRequest(ResponseBuilder rb, 
SearchComponent who, ShardRequest
     }
   }
 
+  @VisibleForTesting
+  static String getDistributedStageName(int stage) {

Review Comment:
   minor/subjective: making this non-static so that custom debug components 
could override to use an alternative (more meaningful) stage name
   ```suggestion
     protected String getDistributedStageName(int stage) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to