janhoy commented on code in PR #2540: URL: https://github.com/apache/solr/pull/2540#discussion_r1660997239
########## solr/bin/solr: ########## @@ -982,31 +982,10 @@ else exit fi +# status tool if [ "$SCRIPT_CMD" == "status" ]; then - if [ $# -gt 0 ]; then - while true; do - case "$1" in - -help|-h) - print_usage "$SCRIPT_CMD" - exit 0 - ;; - --) - shift - break - ;; - *) - if [ "$1" != "" ]; then - print_usage "$SCRIPT_CMD" "Unrecognized or misplaced argument: $1!" - exit 1 - else - break # out-of-args, stop looping - fi - ;; - esac - done - fi get_status - exit + exit $? Review Comment: Only complaint I have is that usage help print in SolrCLI is not very nice. So I did #2545 in main to Improve on it.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
