epugh commented on code in PR #2545:
URL: https://github.com/apache/solr/pull/2545#discussion_r1663193576
##########
solr/core/src/java/org/apache/solr/cli/ToolBase.java:
##########
@@ -66,5 +66,10 @@ public int runTool(CommandLine cli) throws Exception {
return toolExitStatus;
}
+ @Override
Review Comment:
If you are using the default, then do you need to override just to return
null?
##########
solr/core/src/java/org/apache/solr/cli/ToolBase.java:
##########
@@ -66,5 +66,10 @@ public int runTool(CommandLine cli) throws Exception {
return toolExitStatus;
}
+ @Override
Review Comment:
Never mind, this is the base class!!
##########
solr/core/src/test/org/apache/solr/cli/AuthToolTest.java:
##########
@@ -81,7 +81,7 @@ public void testEnableAuth() throws Exception {
private int runTool(String[] args) throws Exception {
Tool tool = findTool(args);
assertTrue(tool instanceof AuthTool);
- CommandLine cli = parseCmdLine(tool.getName(), args, tool.getOptions());
+ CommandLine cli = parseCmdLine(tool, args);
Review Comment:
This new signature is much nicer! I never liked the tool name call...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
