[
https://issues.apache.org/jira/browse/SOLR-17195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-17195.
------------------------------------
Fix Version/s: main (10.0)
9.7
Assignee: Jason Gerlowski
Resolution: Fixed
I'm a bit surprised to come back to this JIRA and see no discussion, and there
was a good bit on the PR itself. To give a quick summary:
- a good bit of discussion around the tradeoff between safety/stability and
inconvenience. i.e. having the limit on by default makes false-positives more
likely (and more annoying), but provides a lot more stability. Ultimately we
settled on keeping the limit disabled by default. We also added the ability to
choose different limits on a per-query basis via local-params, for added
flexibility.
- The initial implementation in the PR very much followed the pattern
established by mBC, and there was some reflection on whether that was a good
thing or not. Would we still accept maxBooleanClauses if it was added today?
etc.
- some debate on how to actuate or scope the limit. e.g. maybe it should only
be applied on certain query parsers or on certain fields. Ultimately (since
it's off by default and can be overridden on a query-by-query basis) we felt
comfortable having it apply to all parsers, etc.
In any case, this PR has been merged and backported to branch_9x - closing this
ticket out.
> Minimum prefix-length soft limit
> --------------------------------
>
> Key: SOLR-17195
> URL: https://issues.apache.org/jira/browse/SOLR-17195
> Project: Solr
> Issue Type: Sub-task
> Components: query
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Major
> Fix For: main (10.0), 9.7
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Solr performs a prefix query by rewriting it as a (potentially) large boolean
> or terms query, with a clause for each term in the "term dictionary" that
> matches the prefix. The shorter the prefix, the more expensive this can be
> and the more likely it is to cause performance problems for users.
> We should add a configurable soft-limit, of the type described in SOLR-17191,
> to prevent users from unknowingly providing very-short-prefixes.
> (This may require coordination and buy-in from the Lucene project, depending
> on implementation details.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
