cpoerschke commented on code in PR #2569: URL: https://github.com/apache/solr/pull/2569#discussion_r1683219989
########## solr/bin/solr: ########## @@ -1446,9 +1446,6 @@ if [ $# -gt 0 ]; then done fi -# Setting number of threads for search -if ! command -v nproc &> /dev/null; then echo "Couldn't determine number of CPUs, using default number of search threads"; else cpus=`nproc`; SCRIPT_SOLR_OPTS+="-Dsolr.searchThreads=$cpus"; fi - Review Comment: @chatman's https://github.com/apache/solr/commit/8299cf3f9a6763d1d728651ad3f2e53fa696a346 commit from the https://github.com/apache/solr/commits/jira/solr-13350-fixes-9x/ branch. ########## solr/server/solr/solr.xml: ########## @@ -34,7 +34,6 @@ <str name="allowPaths">${solr.allowPaths:}</str> <str name="allowUrls">${solr.allowUrls:}</str> <str name="hideStackTrace">${solr.hideStackTrace:false}</str> - <int name="indexSearcherExecutorThreads">${solr.searchThreads:4}</int> Review Comment: Removing the configuration so that the `DEFAULT_INDEX_SEARCHER_EXECUTOR_THREADS` from `NodeConfig.java` gets used. ########## solr/core/src/java/org/apache/solr/core/NodeConfig.java: ########## @@ -627,7 +627,9 @@ public static class NodeConfigBuilder { // No:of core load threads in cloud mode is set to a default of 8 public static final int DEFAULT_CORE_LOAD_THREADS_IN_CLOUD = 8; - public static final int DEFAULT_INDEX_SEARCHER_EXECUTOR_THREADS = 4; + public static final int DEFAULT_INDEX_SEARCHER_EXECUTOR_THREADS = + Runtime.getRuntime().availableProcessors(); + ; Review Comment: @gus-asf's https://github.com/apache/solr/pull/2508#issuecomment-2190481744 suggestion ########## solr/solr-ref-guide/modules/configuration-guide/pages/configuring-solr-xml.adoc: ########## @@ -182,7 +182,7 @@ The default value is equal to the number of processors. + [%autowidth,frame=none] |=== -|Optional |Default: 4 +|Optional |Default: number of available processors Review Comment: Documentation update to match code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
