dsmiley commented on PR #2539: URL: https://github.com/apache/solr/pull/2539#issuecomment-2241815242
`URIBuilder` is in the Apache HttpClient dependency, using it goes in the opposite direction we're trying to go in! Granted in tests, this isn't a priority, so this PR is acceptable. But be mindful please. > We have a patten of "we should do" That could be quite a list; I'm not sure what tracking it accomplishes. If something is important enough, create a JIRA. Ideally when a "we should do" is identified, it can be done everywhere instead of just one spot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
