dsmiley commented on code in PR #2584:
URL: https://github.com/apache/solr/pull/2584#discussion_r1688177033
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##########
@@ -719,6 +695,10 @@ private void refreshCollectionList(Watcher watcher) throws
KeeperException, Inte
* changes.
*/
public void registerCloudCollectionsListener(CloudCollectionsListener
cloudCollectionsListener) {
+ if (cloudCollectionsListeners.isEmpty()) {
Review Comment:
this is not a pure refactor
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##########
@@ -737,6 +717,11 @@ private void notifyCloudCollectionsListeners() {
}
private void notifyCloudCollectionsListeners(boolean notifyIfSame) {
+ if (cloudCollectionsListeners.isEmpty()) {
Review Comment:
this is not a pure refactor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
