gerlowskija commented on PR #2598: URL: https://github.com/apache/solr/pull/2598#issuecomment-2253388336
As I read things the `factoryProp == null` branch is dead code on main/branch_9x, since `randomization.gradle` sets that prop on all builds? I think you're right that with the PR as it stands, any tests that don't use the configsets would now be getting RAMDirectoryFactory, when they didn't previously. In that case maybe the thing to do here isn't to delete the conditional outright but to tweak it so that it sets the same default (i.e. MockDirectoryFactory) as the configs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
