malliaridis commented on PR #2602:
URL: https://github.com/apache/solr/pull/2602#issuecomment-2257981877

   > Lgtm... so.. swapping parsers was possible without forcing any changes to 
the params? It appears this would be totally back wards compatible?!!
   
   Yes, both libraries do almost the same thing just in a different way.
   
   > Have you run the Prometheus export bats test?
   
   Thanks for reminding me. I only ran the java tests and didn't have the bats 
tests in mind. I misused the `OptionGroup` class which caused the bats tests to 
fail. Should work now as expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to