gus-asf commented on code in PR #2596:
URL: https://github.com/apache/solr/pull/2596#discussion_r1700142369
##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -371,7 +371,7 @@ public void process(ResponseBuilder rb) throws IOException {
return;
}
- final boolean multiThreaded = params.getBool("multiThreaded", true);
+ final boolean multiThreaded = params.getBool(CommonParams.MULTI_THREADED,
false);
Review Comment:
+1
##########
solr/CHANGES.txt:
##########
@@ -103,7 +103,7 @@ Other Changes
================== 9.7.0 ==================
New Features
---------------------
-* SOLR-13350: Multithreaded search execution (Ishan Chattopadhyaya, Mark
Miller, Christine Poerschke, David Smiley, noble)
+* SOLR-13350, SOLR-17298: Opt-in multithreaded search execution (Ishan
Chattopadhyaya, Mark Miller, Christine Poerschke, David Smiley, noble, Gus Heck)
Review Comment:
Maybe call it experimental too?
##########
solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc:
##########
@@ -400,6 +400,16 @@ If early termination is used, a `segmentTerminatedEarly`
header will be included
Similar to using <<timeAllowed Parameter,the `timeAllowed` Parameter>>, when
early segment termination happens values such as `numFound`,
xref:faceting.adoc[Facet] counts, and result xref:stats-component.adoc[Stats]
may not be accurate for the entire result set.
+== multiThreaded Parameter
+
+[%autowidth,frame=none]
+|===
+|Optional |Default: `false`
+|===
+
+This parameter set to `true` or `false` controls if Solr may use more than one
thread to satisfy the request.
+It presently is only considered for QueryComponent to search across Lucene's
segments in parallel and the
xref:configuration-guide:configuring-solr-xml.adoc#indexSearcherExecutorThreads[indexSearcherExecutorThreads]
value can be customised in the `solr.xml` file.
Review Comment:
"It presently is only considered" is unclear/confusing. Perhaps
"Specifically this enables"
Also:
"segments in parallel and the xref:..." should either have a comma after
parallel or be broken into two sentences (I prefer 2 sentences)
Also do we have a standardized way to mark things experimental in the docs
(if not just mention it?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
