epugh commented on PR #2593: URL: https://github.com/apache/solr/pull/2593#issuecomment-2266690468
thanks for the testing.. 1. Great to hear! That was an embarassing goof. 2. solr zk -help is no longer valid with our move to using the patterns -h and --help. The docs in branch_9x should be updated (from another PR), so it's okay it doesn't work as long as --help does work! 3. your suggestion was a good one, I hadn't thought about that idea, so really glad we collaborated on it! 4. okay, I was able to run it locally, not sure what is going on. So, I think this is a place where the `bin/solr` and the `bin/solr.cmd` have diveraged, and we need to update `bin/solr.cmd`. Would you be willing to dig into `bin/solr.cmd` and make sure that both `-cloud` and `--cloud` work to start in SolrCloud mode? That way we still have backwards compatibility in the 9x line for the `-cloud`, and then in 10x, we will only support `--cloud`. 5. woot! 6. Similar to 4, I think we need to update `bin/solr.cmd` to pass the arguments through properly. I believe the error message is because in the tool, we look up an `arg` and it doesn't exist. For example, for the ZkRmTool, see the change on https://github.com/apache/solr/pull/2593/files#diff-52ad5182929dc04b5f95c07e284695685a40d56b62899512632459e0137ac086, I think we need something in `bin/solr.cmd`! The bats test suggest that the code works properly between `bin/solr` and the java code, so that is why I think `bin/solr.cmd` needs some love! Feel free to push to this repo, you *may* have to open a PR against my repo. Also a patch file is welcome. Getting closer! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
