aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1707086097
########## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ########## @@ -191,43 +234,23 @@ public void getClusterStatus(NamedList<Object> results) } String configName = clusterStateCollection.getConfigName(); collectionStatus.put("configName", configName); - if (message.getBool("prs", false) && clusterStateCollection.isPerReplicaState()) { + if (solrParams.getBool("prs", false) && clusterStateCollection.isPerReplicaState()) { PerReplicaStates prs = clusterStateCollection.getPerReplicaStates(); collectionStatus.put("PRS", prs); } collectionProps.add(name, collectionStatus); } - List<String> liveNodes = - zkStateReader.getZkClient().getChildren(ZkStateReader.LIVE_NODES_ZKNODE, null, true); - - // now we need to walk the collectionProps tree to cross-check replica state with live nodes - crossCheckReplicaStateWithLiveNodes(liveNodes, collectionProps); - - NamedList<Object> clusterStatus = new SimpleOrderedMap<>(); - clusterStatus.add("collections", collectionProps); - - // read cluster properties - Map<String, Object> clusterProps = zkStateReader.getClusterProperties(); - if (clusterProps != null && !clusterProps.isEmpty()) { - clusterStatus.add("properties", clusterProps); - } - // add the alias map too Map<String, String> collectionAliasMap = aliases.getCollectionAliasMap(); // comma delim if (!collectionAliasMap.isEmpty()) { clusterStatus.add("aliases", collectionAliasMap); Review Comment: added another parameter to fetch all aliases, updated the adoc for CLUSTERSTATUS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org