janhoy commented on code in PR #2629:
URL: https://github.com/apache/solr/pull/2629#discussion_r1709782641


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -55,7 +56,8 @@ public abstract class BaseHttpClusterStateProvider implements 
ClusterStateProvid
   volatile Map<String, Map<String, String>> aliasProperties;
   long aliasesTimestamp = 0;
 
-  private int cacheTimeout = 5; // the liveNodes and aliases cache will be 
invalidated after 5 secs
+  // the liveNodes and aliases cache will be invalidated after 5 secs
+  private int cacheTimeout = 
EnvUtils.getPropertyAsInteger("solr.httpcsp.cache.timeout", 5);

Review Comment:
   Please consider including a category, ref 
[SIP-21](https://cwiki.apache.org/confluence/display/SOLR/SIP-21%3A+Standardize+system+property+naming).
 Candiate could be `solr.cloud.httpcsp.cache.timeout`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to