epugh commented on PR #2381: URL: https://github.com/apache/solr/pull/2381#issuecomment-2282214655
> Should we update documentation too and add any missing information, or should this be handled in a separate ticket instead? > > Looking forward to the HDFS related tests, since I am also curious how it is done. > > It's very nice to see a unified pattern on all CLI classes. And the change of using unified zk host, solr url, help and verbose looks very promising for the future. :) We should add the docs in this one (cause if you don't , they never get added !). As far as the HDFS related tests, honestly I don't think i personally have the energy to figure it out.. I'm going to email the dev and user lists looking for folks to manually test this... I feel like some bats tests should set up an hdfs + solr? Or maybe wrap it in Docker/Docker Compose? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
