timatbw commented on PR #2631: URL: https://github.com/apache/solr/pull/2631#issuecomment-2283973184
Thanks for the reviews. I have pushed a 2nd commit with changes: using `cmd.getPrintableId`, improving test names, adding comments to help read the nested-if. I tried commenting out the `return` statement in the child doc check and one of the new tests failed as we'd expect (the doc was processed when it should have been skipped) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
