malliaridis commented on code in PR #170:
URL: https://github.com/apache/solr/pull/170#discussion_r1716876142
##########
solr/bin/solr:
##########
@@ -757,10 +757,10 @@ function get_info() {
done < <(find "$SOLR_PID_DIR" -name "solr-*.pid" -type f)
else
# no pid files but check using ps just to be sure
- numSolrs=`ps auxww | grep start\.jar | grep solr\.solr\.home | grep -v
grep | wc -l | sed -e 's/^[ \t]*//'`
+ numSolrs=`ps auxww | grep start\.jar | grep solr\.solr\.home=$SOLR_HOME |
grep -v grep | wc -l | sed -e 's/^[ \t]*//'`
if [ "$numSolrs" != "0" ]; then
echo -e "\nFound $numSolrs Solr nodes: "
- PROCESSES=$(ps auxww | grep start\.jar | grep solr\.solr\.home | grep -v
grep | awk '{print $2}' | sort -r)
+ PROCESSES=$(ps auxww | grep start\.jar | grep
solr\.solr\.home=$SOLR_HOME | grep -v grep | awk '{print $2}' | sort -r)
Review Comment:
As far as I understand this change, this hides Solr processes running on a
different solr home directory.
In case of an upgrade of Solr from one version to another, could potentially
cause some issues if a running process from a previous Solr instance is still
running?
##########
solr/bin/solr:
##########
@@ -757,10 +757,10 @@ function get_info() {
done < <(find "$SOLR_PID_DIR" -name "solr-*.pid" -type f)
else
# no pid files but check using ps just to be sure
- numSolrs=`ps auxww | grep start\.jar | grep solr\.solr\.home | grep -v
grep | wc -l | sed -e 's/^[ \t]*//'`
+ numSolrs=`ps auxww | grep start\.jar | grep solr\.solr\.home=$SOLR_HOME |
grep -v grep | wc -l | sed -e 's/^[ \t]*//'`
if [ "$numSolrs" != "0" ]; then
echo -e "\nFound $numSolrs Solr nodes: "
- PROCESSES=$(ps auxww | grep start\.jar | grep solr\.solr\.home | grep -v
grep | awk '{print $2}' | sort -r)
+ PROCESSES=$(ps auxww | grep start\.jar | grep
solr\.solr\.home=$SOLR_HOME | grep -v grep | awk '{print $2}' | sort -r)
Review Comment:
As far as I understand this change, this hides Solr processes running on a
different solr home directory.
In case of an upgrade of Solr from one version to another, could potentially
cause some issues if a running process from a previous Solr instance is still
running?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
