[
https://issues.apache.org/jira/browse/SOLR-17180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874355#comment-17874355
]
Eric Pugh commented on SOLR-17180:
----------------------------------
Thanks [~houston]... so let me see if I can answer, and there are maybe a
couple of perspectives...
The perspective of why use bin/solr CLI to hit the various snapshot apis...
The theory is that since bin/solr supports basic auth, and will support the
other auth methods some day, that is easier then just using a API. It's the
theory behind a number of the commands that predominantly delegate to an API.
Also, it was easier for me to eliminate snapshotscli.sh by saying "just use
bin/solr instead" versus just straight up deleting it in 10!
Now, I can't speak to the use of the BackupAPI and the SnapshotAPI and all of
those.. There does seem to be some overlap an devolution around them, and if
someday we have bin/solr backup commands instead of bin/solr snapshot commands,
well, that seems great!
Thirdly, I wanted to make sure that core Solr didn't have any direct
dependencies on modules/hdfs, which with out this it does... This opens the
door up to deprecateing HDFS in 10 or doing other things. Also, core solr in
the form of that snapshots.cli.sh has specific to HDFS code, now it can live
nicely in modules/hdfs/bin directory! (I kind of like that we now have a
pattern for shipping scripts that are Module specific).
And maybe lastly, I really am pushing hard to get ALL cli's/scripts in Solr to
work the same and look the same, and so this goes towards that direction.
If there is code to deprecate, I'm all for it, however I think getting this
merged is worth it on it's own for the above reasons.
> Migrate snapshotscli.sh code into bin/solr and hdfs module code
> ---------------------------------------------------------------
>
> Key: SOLR-17180
> URL: https://issues.apache.org/jira/browse/SOLR-17180
> Project: Solr
> Issue Type: Sub-task
> Components: cli, hdfs
> Reporter: Eric Pugh
> Assignee: Eric Pugh
> Priority: Major
>
> There is a file in ./server/scripts/cloud-scripts/ called snapshotscli.sh.
> We have no documentation about it in the ref guide, and it appears to expose
> the class
> org.apache.solr.hdfs.snapshots.SolrSnapshotsTool.java
>
> Seems like this should be distributed as part of the hdfs Module, not buried
> way down deep inside of the core of Solr.
> Maybe it should be in ./modules/hdfs/bin directory? Or
> ./modules/hdfs/scripts directory in the Solr distribution?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
