epugh commented on code in PR #2656:
URL: https://github.com/apache/solr/pull/2656#discussion_r1727154578


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBase.java:
##########
@@ -121,7 +121,7 @@ protected ResponseParser responseParser(SolrRequest<?> 
solrRequest) {
     return solrRequest.getResponseParser() == null ? this.parser : 
solrRequest.getResponseParser();
   }
 
-  protected ModifiableSolrParams initalizeSolrParams(
+  protected ModifiableSolrParams initializeSolrParams(

Review Comment:
   Dunno...   Would a 3rd party sub class immediately break and then you fix 
it?  I could easily do the deprecation however if you think that is just the 
easier process.....   Especailly for backporting...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to