epugh commented on code in PR #2651:
URL: https://github.com/apache/solr/pull/2651#discussion_r1729415225
##########
solr/core/src/java/org/apache/solr/util/FileTypeMagicUtil.java:
##########
@@ -60,6 +60,14 @@ public static void assertConfigSetFolderLegal(Path confPath)
throws IOException
new SimpleFileVisitor<>() {
@Override
public FileVisitResult visitFile(Path file, BasicFileAttributes
attrs) {
+ if (Files.isSymbolicLink(file)) {
Review Comment:
So, right now symbolic links don't work, they blow up with a cryptic error.
This PR 's goal is to replace the cryptic error with a nicer error! I think
your suggestion is interesting, and if we wanted to support symbolic link
lookup, that sounds like a nice addition to do in a separate PR that removes
the limitation. It isn't an immediate itch for me to scratch however. Does
that sound reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
