[
https://issues.apache.org/jira/browse/SOLR-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878651#comment-17878651
]
David Smiley commented on SOLR-6572:
------------------------------------
We don't normally trim our configuration values at a higher level (code
interpreting a particular config value); I think it's very haphazard to do it
on-read (like once we do it here and there, then everywhere we wonder, should
we do here too? a mess IMO).
I understand that a leading or trailing space might be pertinent in some edge
cases. Couldn't this be addressed with an attribute like trim="false"
(defaulting to true)?
> lineshift in solrconfig.xml is not supported
> --------------------------------------------
>
> Key: SOLR-6572
> URL: https://issues.apache.org/jira/browse/SOLR-6572
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.8.1
> Reporter: Fredrik Rodland
> Assignee: Jan Høydahl
> Priority: Major
> Labels: difficulty-easy, impact-low, solrconfig.xml
> Fix For: 9.7
>
> Attachments: SOLR-6572.patch, SOLR-6572.unittest
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> This has been a problem for a long time, and is still a problem at least for
> SOLR 4.8.1.
> If lineshifts are introduced in some elements in solrconfig.xml SOLR fails to
> pick up on the values.
> example:
> ok:
> {code}
> <requestHandler name="/replication" class="solr.ReplicationHandler"
> enable="${enable.replication:false}">
> <lst name="slave">
> <str
> name="masterUrl">${solr.master.url:http://solr-admin1.finn.no:12910/solr/front-static/replication}</str>
> {code}
> not ok:
> {code}
> <requestHandler name="/replication" class="solr.ReplicationHandler"
> enable="${enable.replication:false}">
> <lst name="slave">
> <str
> name="masterUrl">${solr.master.url:http://solr-admin1.finn.no:12910/solr/front-static/replication}
> </str>
> {code}
> Other example:
> ok:
> {code}
> <str
> name="shards">localhost:12100/solr,localhost:12200/solr,localhost:12300/solr,localhost:12400/solr,localhost:12500/solr,localhost:12530/solr</str>
> {code}
> not ok:
> {code}
> <str name="shards">
> localhost:12100/solr,localhost:12200/solr,localhost:12300/solr,localhost:12400/solr,localhost:12500/solr,localhost:12530/solr
> </str>
> {code}
> IDEs and people tend to introduce lineshifts in xml-files to make them
> prettyer. SOLR should really not be affected by this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
