cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1753672888
##########
solr/core/src/test/org/apache/solr/cloud/ReplicateFromLeaderTest.java:
##########
@@ -28,44 +28,64 @@ public class ReplicateFromLeaderTest {
public void determinePollIntervalString() {
SolrConfig.UpdateHandlerInfo updateHandlerInfo =
new SolrConfig.UpdateHandlerInfo(
- "solr.DirectUpdateHandler2", -1, 15000, -1, true, -1, 60000,
false);
+ "solr.DirectUpdateHandler2", -1, 15000, -1, true, -1, 60000,
false, null);
String pollInterval =
ReplicateFromLeader.determinePollInterval(updateHandlerInfo);
assertEquals("0:0:7", pollInterval);
updateHandlerInfo =
new SolrConfig.UpdateHandlerInfo(
- "solr.DirectUpdateHandler2", -1, 60000, -1, true, -1, 15000,
false);
+ "solr.DirectUpdateHandler2", -1, 60000, -1, true, -1, 15000,
false, null);
pollInterval =
ReplicateFromLeader.determinePollInterval(updateHandlerInfo);
assertEquals("0:0:30", pollInterval);
updateHandlerInfo =
new SolrConfig.UpdateHandlerInfo(
- "solr.DirectUpdateHandler2", -1, 15000, -1, false, -1, 60000,
false);
+ "solr.DirectUpdateHandler2", -1, 15000, -1, false, -1, 60000,
false, null);
pollInterval =
ReplicateFromLeader.determinePollInterval(updateHandlerInfo);
assertEquals("0:0:30", pollInterval);
updateHandlerInfo =
new SolrConfig.UpdateHandlerInfo(
- "solr.DirectUpdateHandler2", -1, 60000, -1, false, -1, 15000,
false);
+ "solr.DirectUpdateHandler2", -1, 60000, -1, false, -1, 15000,
false, null);
pollInterval =
ReplicateFromLeader.determinePollInterval(updateHandlerInfo);
assertEquals("0:0:30", pollInterval);
updateHandlerInfo =
new SolrConfig.UpdateHandlerInfo(
- "solr.DirectUpdateHandler2", -1, -1, -1, false, -1, 60000, false);
+ "solr.DirectUpdateHandler2", -1, -1, -1, false, -1, 60000, false,
null);
pollInterval =
ReplicateFromLeader.determinePollInterval(updateHandlerInfo);
assertEquals("0:0:30", pollInterval);
updateHandlerInfo =
new SolrConfig.UpdateHandlerInfo(
- "solr.DirectUpdateHandler2", -1, 15000, -1, false, -1, -1, false);
+ "solr.DirectUpdateHandler2", -1, 15000, -1, false, -1, -1, false,
null);
pollInterval =
ReplicateFromLeader.determinePollInterval(updateHandlerInfo);
assertEquals("0:0:7", pollInterval);
updateHandlerInfo =
new SolrConfig.UpdateHandlerInfo(
- "solr.DirectUpdateHandler2", -1, 60000, -1, true, -1, -1, false);
+ "solr.DirectUpdateHandler2", -1, 60000, -1, true, -1, -1, false,
null);
pollInterval =
ReplicateFromLeader.determinePollInterval(updateHandlerInfo);
assertEquals("0:0:30", pollInterval);
+
+ updateHandlerInfo =
+ new SolrConfig.UpdateHandlerInfo(
+ "solr.DirectUpdateHandler2", -1, 60000, -1, true, -1, -1, false,
"0:0:56");
+ pollInterval =
ReplicateFromLeader.determinePollInterval(updateHandlerInfo);
+ assertEquals("0:0:56", pollInterval);
+
+ updateHandlerInfo =
+ new SolrConfig.UpdateHandlerInfo(
+ "solr.DirectUpdateHandler2",
+ -1,
+ 60000,
+ -1,
+ true,
+ -1,
+ -1,
+ false,
+ "garbage-unfortunately");
+ pollInterval =
ReplicateFromLeader.determinePollInterval(updateHandlerInfo);
+ assertEquals("garbage-unfortunately", pollInterval);
Review Comment:
Perhaps `ReplicationHander.readIntervalNs` could be made public and used to
validate either in UpdateHandlerInfo or in determinePollInterval. With
`expectThrows(...)` in the test logic here then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
