epugh commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1765299626
##########
solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java:
##########
@@ -170,7 +172,15 @@ protected void runCloudTool(CloudSolrClient
cloudSolrClient, CommandLine cli) th
q = new SolrQuery("*:*");
q.setRows(0);
q.set(DISTRIB, "false");
- try (var solrClientForCollection = SolrCLI.getSolrClient(coreUrl)) {
+
+ // SolrCLI.getSolrClient converts the coreUrl back into a root Solr
url, but we need to
+ // talk to specific core so manually creating the client.
Review Comment:
Humm..... I read it and it says:
```
/**
* Get a SolrClient for the given URL. The URL can be with or without
/solr suffix, the method
* will normalize it and add '/solr'. To support certain unit tests, the
hostContext can be
* overridden via the system property 'hostContext'.
*
* <p>Note that from Solr 10.0 Solr will use / as base URL to support /api
and other contexts, so
* handling of hostContext differs between Solr 9.x and 10.x.
*
* @param solrUrl the base URL of Solr
* @return a SolrClient initialized with correct hostContext, default
'/solr'
*/
public static SolrClient getSolrClient(String solrUrl) {
```
I think this is the only place we need a core specific url... Do you think
it should support that use case as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
