[ 
https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885092#comment-17885092
 ] 

Matthew Biscocho commented on SOLR-16470:
-----------------------------------------

Ah ok, think I figured it out. Not a regression, API works fine and I get back 
the raw bytes. 
{code:java}
curl --output - 
'localhost:8983/solr/<collectionName>/replication?command=filecontent&cf=./solrconfig.xml&wt=filestream'
 {code}
Just looks like if you don't pass all the correct parameters, it's just doing 
that useless Object.toString() output and since your commit change, doesn't 
have access to call toString on that private object anymore. May not actually 
matter since probably nothing internally calls this api like that anyways which 
is why no tests fail but we get back a http/500 instead of http/200. If you're 
ok with it, maybe I'll throw in an error code with a message response about 
some missing parameters and incorrect use of the API.

> Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get 
> File List
> ---------------------------------------------------------------------------------------
>
>                 Key: SOLR-16470
>                 URL: https://issues.apache.org/jira/browse/SOLR-16470
>             Project: Solr
>          Issue Type: Sub-task
>          Components: v2 API
>    Affects Versions: 9.2
>            Reporter: Sanjay Dutt
>            Priority: Major
>              Labels: V2, newdev
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> Replication Handler has no v2 equivalent. This ticket is covering few 
> endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, 
> Get File List.
> Existing V1
> |-GET /solr/collName/replication?command=indexversion-|
> |GET /solr/collName/replication?command=filecontent|
> |-GET /solr/collName/replication?command=filelist-|
> Proposed API design
> |-GET /api/cores/coreName/replication/indexversion-|
> |GET /api/cores/coreName/replication/files/filePath|
> |-GET /api/cores/coreName/replication/files-|
>  few other pointers that might be helpful, especially for newcomers:
>  * The v1 logic for this API lives in ReplicationHandler
>  * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" 
> section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr]
>  * [A step-by-step guide to creating APIs using the preferred v2 API 
> framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis]
>  * [A recent PR that adds a v2 API, as an 
> example|https://github.com/apache/solr/pull/2144]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to